Prevent empty projected volumes#531
Open
mfrailis wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for interlink-dev canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts when projected volume data is added to the PodCreateRequest so the appended entry contains the fully populated data from all projection sources.
Changes:
- Move
ProjectedVolumeMapsappend to after allvolume.Projected.Sourceshave been processed - Consolidate the debug log of
ProjectedVolumeMapslength to run once after append
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thank you @mfrailis ! Let e get through it and the copilot first comments, and then I'll be back to you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I anticipate that I'm not a Golang programmer, so I may have misinterpreted the code.
When testing interlink in order to bridge kubernetes with a slurm managed HPC cluster, I experienced empty projected volumes within the slurm jobs created by InterLink.
Initially I did not set the SHARED_FS=true, so setting it surely solve the problem. But in any case, this pull request seems to correct a bug in the VirtualKubelet code, which can cause the forwarding of an empty projected volume to the slurm bridge.
Apologize in case this is a false alarm.